Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If we're knocked out, we'll drop any object that we're holding #691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VinniTR
Copy link
Contributor

@VinniTR VinniTR commented Apr 22, 2024

Description

If we're knocked out and we're holding a object, we'll drop it immediately.

Type of Changes

Type
βœ“ πŸ› Bug fix

@Loup-Garou911XD
Copy link
Contributor

why do i feel i have seen this pr before?

@Loup-Garou911XD
Copy link
Contributor

why do i feel i have seen this pr before?

ohh okay #530 was closed because of limitations of bombsquad

@EraOSBeta
Copy link
Contributor

Doesn't this face the exact same issue as #530? since this stuff isn't server-side only

@EraOSBeta
Copy link
Contributor

EraOSBeta commented Nov 8, 2024

Alright so I was on-board with having this be merged for scenev2 as one of the many minor engine issues that need fixing; but now I'm against having this in the C++ layer since with the current behavior, mods could possibly use knocked-out spaz nodes that are holding other nodes as a way to create chain-like objects (maybe, haven't tested it). So I would personally recommend any logic of this kind (along with any other non-heavy-performance limitations currently in the spaz node code) to be moved to the Python layer and in the Spaz class instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants